Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#609 avoids some duplicated metrics #681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#609 avoids some duplicated metrics #681

wants to merge 1 commit into from

Commits on Feb 14, 2022

  1. prometheus#609 avoids some duplicated metrics 

    Including `records-lag-avg` and `records-lag-max` explicitly avoids `kafka_connect_consumer_fetch_records_lag` mixing its values as seen here:
```
kafka_connect_consumer_fetch_records_lag{clientId="foo",partition="0",topic="bar",} 0.0
kafka_connect_consumer_fetch_records_lag{clientId="foo",partition="0",topic="bar",} NaN
kafka_connect_consumer_fetch_records_lag{clientId="foo",partition="0",topic="bar",} NaN
```
After applying this change:
```
# HELP kafka_connect_consumer_fetch_records_lag Kafka Connect JMX metric type consumer-fetch-manager
# TYPE kafka_connect_consumer_fetch_records_lag gauge
kafka_connect_consumer_fetch_records_lag{clientId="foo",partition="0",topic="bar",} 0.0
# HELP kafka_connect_consumer_fetch_records_lag_avg Kafka Connect JMX metric type consumer-fetch-manager
# TYPE kafka_connect_consumer_fetch_records_lag_avg gauge
kafka_connect_consumer_fetch_records_lag_avg{clientId="foo",partition="0",topic="bar",} NaN
# HELP kafka_connect_consumer_fetch_records_lag_max Kafka Connect JMX metric type consumer-fetch-manager
# TYPE kafka_connect_consumer_fetch_records_lag_max gauge
kafka_connect_consumer_fetch_records_lag_max{clientId="foo",partition="0",topic="bar",} NaN
```
    @superfav
    superfav committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    d2ce1e6 View commit details
    Browse the repository at this point in the history