Change format of listen on vsock #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, node_exporter can run with `--web.listen-address=vsock: //:9100` to listen on vsock in qemu guest. Then host can get the metrics. Signed-off-by: Jeffrey Zhang <zhang.lei.fly@gmail.com>
Leonid99
force-pushed
the
leonid/vsock
branch
2 times, most recently
from
122811e
to
5eed0a8
Compare
|
Found #202 after publishing this PR. Should I just close this one? (They are identical, except for the expected format of the command line flag). |
|
I think the other PR is mostly ready to go. Would you be interested in adding to the tests as mentioned in the comments after I merge it? |
|
If you have any comments on the other PR, feel free to contribute there. |
Left a few comments. |
Signed-off-by: Leonid Podolny <leonid@podolny.net>
|
@SuperQ I rebased this branch on top of the one by @jeffrey4l to address my own remarks in his #202. Would you be interested in me rebasing this branch to resolve conflicts, so that we can merge it? I will obviously keep @jeffrey4l 's commits untouched to keep proper credit. |
Leonid99
force-pushed
the
leonid/vsock
branch
2 times, most recently
from
6c78537
to
163145b
Compare
Before this change, the expected format of listening on vsock was "--web.listen-address=vsock://:9100". However, this URI-inspired format is probably confusing, especially given that it doesn't really support the host portion of the URI and that listening on TCP doesn't support the "http://:9100" syntax. This commit changes the expected format for vsock to be "--web.listen-address=vsock:9100". Signed-off-by: Leonid Podolny <leonid@podolny.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the expected format of listening on
vsock was "--web.listen-address=vsock://:9100".
However, this URI-inspired format is probably confusing,
especially given that it doesn't really support the host
portion of the URI and that listening on TCP doesn't
support the "http://:9100" syntax.
This commit changes the expected format for vsock to be
--web.listen-address=vsock:9100.