New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promql+alert_generator: Dockerized the toolset, updated docs. #46
Conversation
I guess one idea is to move some (non SaaS) e2e tests to here directly (similar to thanos-io/thanos#4781) - it's portable, docker based so should be working fine, like we do for agent's remote write send tests. |
Thanks! Hmmm, I already have a local change that I didn't manage to push yet out of time constraints this week that just allows you to repeat the |
Is it for the same reason? If yes than I would say separate specific ones might be more clear. If there is another reason, let's go with a repeated one, it will do the work too. I can rebase later on 👍🏽 |
See comments in #48 (comment), will review this PR again after rebase :) |
@bwplotka Do you still want to update / rebase this PR? (either keeping your way of doing configs or mine) |
@bwplotka any update on this? |
Sorry, I don't follow GH notifications... and I need this PR again for dockerizing alerting compliance too ;p Let me rebase and try again! |
Motivation for this is that we can now set automated tests where in future we might want to provide docker images with exact set of test cases in versioned image. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Updated, PTAL @juliusv @GiedriusS and @codesome (: See working example: thanos-io/thanos#5315 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just sprinkling some articles and stuff like that onto my part of the code base ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the alert_generator addition. Thanks!
Co-authored-by: Julius Volz <julius.volz@gmail.com>
Co-authored-by: Julius Volz <julius.volz@gmail.com>
Thanks! Addressed (: |
Additionally updated docs.
The motivation for this is that we can now set automated tests where in future we might want to provide docker images with exact set of test cases in versioned image.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com