Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promql+alert_generator: Dockerized the toolset, updated docs. #46

Merged
merged 3 commits into from May 9, 2022

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Oct 14, 2021

Additionally updated docs.

The motivation for this is that we can now set automated tests where in future we might want to provide docker images with exact set of test cases in versioned image.

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka
Copy link
Member Author

I guess one idea is to move some (non SaaS) e2e tests to here directly (similar to thanos-io/thanos#4781) - it's portable, docker based so should be working fine, like we do for agent's remote write send tests.

@juliusv
Copy link
Member

juliusv commented Oct 15, 2021

Thanks! Hmmm, I already have a local change that I didn't manage to push yet out of time constraints this week that just allows you to repeat the -config-file flag, which leads to simply concatenating config files before YAML parsing. That allows for even more general config splitting, what do you think? I wanted to just push it now.

@bwplotka
Copy link
Member Author

bwplotka commented Oct 15, 2021

Is it for the same reason?

If yes than I would say separate specific ones might be more clear.

If there is another reason, let's go with a repeated one, it will do the work too. I can rebase later on 👍🏽

@juliusv
Copy link
Member

juliusv commented Oct 18, 2021

See comments in #48 (comment), will review this PR again after rebase :)

@juliusv
Copy link
Member

juliusv commented Oct 31, 2021

@bwplotka Do you still want to update / rebase this PR? (either keeping your way of doing configs or mine)

@GiedriusS
Copy link

@bwplotka any update on this?

@bwplotka
Copy link
Member Author

Sorry, I don't follow GH notifications... and I need this PR again for dockerizing alerting compliance too ;p Let me rebase and try again!

@bwplotka bwplotka changed the title promql: Dockerized the tool; split cases and config for easier reuse. promql: Dockerized the tool Apr 28, 2022
Motivation for this is that we can now set automated tests where in future we might want to provide
docker images with exact set of test cases in versioned image.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

Updated, PTAL @juliusv @GiedriusS and @codesome (:

See working example: thanos-io/thanos#5315

@bwplotka bwplotka changed the title promql: Dockerized the tool promql+alert_generator: Dockerized the toolset, updated docs. Apr 28, 2022
Copy link
Member

@juliusv juliusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sprinkling some articles and stuff like that onto my part of the code base ;)

alert_generator/README.md Outdated Show resolved Hide resolved
promql/README.md Outdated Show resolved Hide resolved
promql/README.md Outdated Show resolved Hide resolved
promql/README.md Outdated Show resolved Hide resolved
promql/README.md Outdated Show resolved Hide resolved
promql/README.md Outdated Show resolved Hide resolved
Copy link
Member

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the alert_generator addition. Thanks!

bwplotka and others added 2 commits May 9, 2022 15:38
Co-authored-by: Julius Volz <julius.volz@gmail.com>
Co-authored-by: Julius Volz <julius.volz@gmail.com>
@bwplotka
Copy link
Member Author

bwplotka commented May 9, 2022

Thanks! Addressed (:

@bwplotka bwplotka merged commit 5ddf182 into main May 9, 2022
@bwplotka bwplotka deleted the dockerfile branch May 9, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants