Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common interface to fetch secrets in HTTP client config #538

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheSpiritXIII
Copy link
Contributor

@TheSpiritXIII TheSpiritXIII commented Nov 30, 2023

Part 1 for secret provider support within common. See: https://groups.google.com/g/prometheus-developers/c/WKOej_pnhXg

This change consolidates fetching secrets across all authorization types. Authorization types which previously had different structs per secret type now have a single type.

The unification helps with adding secret manager support which part 2 will include. There are two ways we could do this.

  1. With a secret "reference" (or "handle"), e.g. a name to a secret which is configured somewhere else. This PR implements this approach: Add support for secret refs via a secret manager #572
  2. Inline. This would not be backwards-compatible. The only way I could think of serialization to work with the type defined outside of this package (secret provider configs would be part of the main prometheus repository since they're plugins), is to use a generic secret config type.

@TheSpiritXIII TheSpiritXIII force-pushed the http-secret-interface branch 2 times, most recently from 0d08b50 to 95e1bd7 Compare November 30, 2023 19:06
@TheSpiritXIII TheSpiritXIII force-pushed the http-secret-interface branch 2 times, most recently from 377cde8 to aa94e76 Compare December 13, 2023 22:31
@TheSpiritXIII TheSpiritXIII force-pushed the http-secret-interface branch 3 times, most recently from 3c3e1cc to 4a41b93 Compare February 2, 2024 13:53
@TheSpiritXIII TheSpiritXIII marked this pull request as ready for review February 12, 2024 20:23
Signed-off-by: Daniel Hrabovcak <thespiritxiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant