Add Sigv4 Endpoint config parameter #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanwren
force-pushed
the
kanwren/add-sigv4-endpoint-parameter
branch
from
bccc2dc
to
4faba52
Compare
|
Any chance on getting this merged? It would be very helpful for AWS VPC deployments that need to keep all network traffic within AWS. |
Signed-off-by: Nicole Wren <wrenn@squareup.com>
kanwren
force-pushed
the
kanwren/add-sigv4-endpoint-parameter
branch
from
4faba52
to
3442f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes an
endpointfield in the sigv4 config, so that the call to STS when assuming a role with a web identity can use a custom STS endpoint, e.g. a VPC endpoint.No clients other than the STS one are made from the session config here, so setting
Endpointshould be safe, but it can also be a resolver if this is a concern.Addresses prometheus/prometheus#11710.