Add color logging capabilities for promlog #457
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick color logging functionality from #113. Signed-off-by: SuperQ <superq@gmail.com>
|
Can we make this opt in with a flag --log.color ? |
|
@roidelapluie Sure, done. I made it opt-out. 😁 |
SuperQ
force-pushed
the
superq/pr_113
branch
from
a15ed67
to
9227990
Compare
SuperQ
force-pushed
the
superq/pr_113
branch
from
72fdbae
to
b989e95
Compare
Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/pr_113
branch
from
b989e95
to
9a047ac
Compare
|
I am pretty sure making it opt out will be an annoyance. It's also personal taste of course. |
|
We are using a trick to look at the stack to print the file and line number. It might be worth it to double check that this does not get in the way. |
|
I have tested the PR and it does not work. |
|
Boo, ok. I'll poke around to see if I can make it work. I was just trying to rebase on the old PR. |
|
Even when I fix the error in the code, I don't see the errors in my
terminal.
Le sam. 25 févr. 2023, 18:27, Ben Kochie ***@***.***> a
écrit :
… Boo, ok. I'll poke around to see if I can make it work. I was just trying
to rebase on the old PR.
—
Reply to this email directly, view it on GitHub
<#457 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHHJXL7I7IGXNS43KXPBLWZI6JPANCNFSM6AAAAAAVHZITUM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick color logging functionality from #113.