TLS config: Enable selection of min and max TLS version #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on. We might want the default to be tls1.2 and change it in Prometheus itself. |
go1.18 changes the default minimum TLS version to 1.2. In order not to break our users, let's make the default minimum version configurable. The allowed values (TLS10, ..) come from the exporter-toolkit: https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md TLSVersion is exported so the exporter toolkit can reuse them later. DefaultTLSVersion is exposed so Prometheus can keep a conservative default. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
roidelapluie
force-pushed
the
tlsversion
branch
from
13bf214
to
734398a
Compare
|
Closed for #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.18 changes the default minimum TLS version to 1.2.
In order not to break our users, let's make the default minimum version
configurable, with conservative defaults.
The allowed values (TLS10, ..) come from the exporter-toolkit:
https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md
TLSVersion is exported so the exporter toolkit can reuse them later.
Signed-off-by: Julien Pivotto roidelapluie@o11y.eu