Add sigv4 config to common #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d secret key Signed-off-by: Tyler Reid <tyler.reid@grafana.com> Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
5 tasks
|
Hello, I do not think sigv4 belongs in config. We should instead have the sigv4 config and the roundtripper in a github.com/prometheus/common/sigv4 package, together with its own go.mod. That way, we can reuse the code easily between Prometheus RW and alertmanager without ading AWS as dependency of common. Thanks. |
|
Oh! I totally misunderstood, I can do that! I'm going to close this PR and make a new one with the sigv4 module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here: prometheus/alertmanager#2559 (comment)
Will throw error if a user doesn't supply username and secret key
Signed-off-by: Tyler Reid tyler.reid@grafana.com