Fix unmarshal of negative times #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
force-pushed
the
negative_time_unmarshal
branch
2 times, most recently
from
a663b5f
to
c2588c8
Compare
|
Could you add a unittest for this? |
Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
jacksontj
force-pushed
the
negative_time_unmarshal
branch
from
c2588c8
to
3e87181
Compare
|
There weren't any tests for time marshal/Unmarshal, so I added a couple. |
|
Thanks! |
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
…_overridable Log X-Forwarded-For (or similar) for every request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding tests in prometheus/client_golang#570 I noticed that this
model.Timedoesn't properly unmarshal negative times.