Return 0.0.1 with no version for backwards compatibility

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
prometheus · Apr 28, 2023 · ad42fa5 · ad42fa5
1 parent 5012e7c
commit ad42fa5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/expfmt/encode.go b/expfmt/encode.go
@@ -100,10 +100,10 @@ func NegotiateIncludingOpenMetrics(h http.Header) Format {
 			return FmtText
 		}
 		if ac.Type+"/"+ac.SubType == OpenMetricsType && (ver == OpenMetricsVersion_0_0_1 || ver == OpenMetricsVersion_1_0_0 || ver == "") {
-			if ver == OpenMetricsVersion_0_0_1 {
-				return FmtOpenMetrics_0_0_1
+			if ver == OpenMetricsVersion_1_0_0 {
+				return FmtOpenMetrics_1_0_0
 			}
-			return FmtOpenMetrics_1_0_0
+			return FmtOpenMetrics_0_0_1
 		}
 	}
 	return FmtText

diff --git a/expfmt/encode_test.go b/expfmt/encode_test.go
@@ -72,7 +72,7 @@ func TestNegotiateOpenMetrics(t *testing.T) {
 		{
 			name:              "OM format, no version",
 			acceptHeaderValue: "application/openmetrics-text",
-			expectedFmt:       string(FmtOpenMetrics_1_0_0),
+			expectedFmt:       string(FmtOpenMetrics_0_0_1),
 		},
 		{
 			name:              "OM format, 0.0.1 version",