examples/actix-web.rs: Default enable compress middleware. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the proposal. I still remember compression not being a silver bullet. E.g. see kubernetes/kube-state-metrics#498. Is this the default in other client libraries? Have you done any measurements with and without? |
|
This is the default in the Go library: https://github.com/prometheus/client_golang/blob/93cf5d4f5f78058ef0e5fe5fbf597de2084c64fd/prometheus/promhttp/http.go#L172-L175 - I haven't done any measurements yet. |
mxinden
reviewed
Mar 30, 2024
Signed-off-by: Jonathan Davies <jpds@protonmail.com>
jpds
force-pushed
the
examples-actix-compress
branch
from
05b6480
to
fa3e8c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.