Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax type constraints Timestamp #758

Merged
merged 1 commit into from
Jan 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions prometheus_client/samples.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Dict, NamedTuple, Optional
from typing import Dict, NamedTuple, Optional, Union


class Timestamp:
Expand Down Expand Up @@ -39,12 +39,12 @@ def __gt__(self, other):
class Exemplar(NamedTuple):
labels: Dict[str, str]
value: float
timestamp: Optional[float] = None
timestamp: Optional[Union[float, Timestamp]] = None


class Sample(NamedTuple):
name: str
labels: Dict[str, str]
value: float
timestamp: Optional[float] = None
timestamp: Optional[Union[float, Timestamp]] = None
exemplar: Optional[Exemplar] = None