Add missing functions/classes to __all__ #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Pliner <yury.pliner@gmail.com>
Pliner
force-pushed
the
add-collector-registry-and-registry-back
branch
from
d8d8f0c
to
0c66ee1
Compare
|
@csmarchbanks Could you look on it please? |
|
Also, it would be nice if this would fail in our linter, perhaps as part of this PR you could add |
Signed-off-by: Yury Pliner <yury.pliner@gmail.com>
Pliner
force-pushed
the
add-collector-registry-and-registry-back
branch
2 times, most recently
from
9253a31
to
8122061
Compare
Signed-off-by: Yury Pliner <yury.pliner@gmail.com>
Pliner
force-pushed
the
add-collector-registry-and-registry-back
branch
2 times, most recently
from
e9d1446
to
c7e9c19
Compare
prometheus_client/__init__.py:7: error: Module "prometheus_client.exposition" does not explicitly export attribute "make_asgi_app"; implicit reexport disabled Signed-off-by: Yury Pliner <yury.pliner@gmail.com>
Pliner
force-pushed
the
add-collector-registry-and-registry-back
branch
from
c7e9c19
to
e75aa84
Compare
Pliner
changed the title
Pliner
changed the title
|
@csmarchbanks Done. Thanks for the fast feedback! |
Pliner
commented
Jan 28, 2022
| @@ -17,6 +17,21 @@ | |||
| from .registry import REGISTRY | |||
| from .utils import floatToGoString | |||
|
|
|||
| __all__ = ( | |||
There was a problem hiding this comment.
I'm a bit unsure about this, but had to explicitly export in this way because of make_asgi_app.
There was a problem hiding this comment.
prometheus_client/__init__.py:7: error:Module "prometheus_client.exposition" does not explicitly export attribute "make_asgi_app"; implicit reexport disabled
There was a problem hiding this comment.
This seems fine to me, it makes it very clear that those are the things we are exporting.
csmarchbanks
approved these changes
Jan 28, 2022
| @@ -17,6 +17,21 @@ | |||
| from .registry import REGISTRY | |||
| from .utils import floatToGoString | |||
|
|
|||
| __all__ = ( | |||
There was a problem hiding this comment.
This seems fine to me, it makes it very clear that those are the things we are exporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
mypy==0.931.0raises the following errors forprometheus-client==0.13.0:Probably the reason of it are two things:
__all__declaration and I have no idea why it worked before.I hope it is fine to include these two things to
__all__, because of their wider usage compared to other classes/constants mentioned in #747.Thanks.