Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go #71

Merged
merged 1 commit into from Oct 2, 2023
Merged

Update Go #71

merged 1 commit into from Oct 2, 2023
+18 −4

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Oct 2, 2023

  • Enable dependabot monthly updates.
  • Update Go minimum to 1.19.
  • Update Go modules.

@SuperQ
Update Go
568c466 
* Enable dependabot monthly updates.
* Update Go minimum to 1.19.
* Update Go modules.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from bboreham October 2, 2023 16:46
bboreham
bboreham approved these changes Oct 2, 2023
View reviewed changes
go.mod
@@ -1,5 +1,5 @@
module github.com/prometheus/client_model

go 1.18
go 1.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this does not "Update Go minimum to 1.19", unless the user is running Go 1.21 or later.
Before that the version here is advisory only, and will not stop someone from using Go 1.18.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I know it's advisory, but it still means "This is the minimum".

@SuperQ SuperQ merged commit cbe84de into master Oct 2, 2023
3 checks passed
@SuperQ SuperQ deleted the superq/update_build branch October 2, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperQ @bboreham