Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Go 1.17 collector thread-safe #969

Merged
merged 1 commit into from Jan 21, 2022
Merged

Make the Go 1.17 collector thread-safe #969

merged 1 commit into from Jan 21, 2022

Commits on Jan 21, 2022

  1. Make the Go 1.17 collector thread-safe 

    Currently the Go 1.17 collector does not protect access to rmSampleBuf,
and Collect may be invoked concurrently. This change adds a mutex around
all uses of rmSampleBuf and pulls out operations that may block on
channels, so concurrent calls to Collect can at least pipeline those two
operations.

Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
    @mknyszek
    mknyszek committed Jan 21, 2022
    Copy the full SHA
    aba7051 View commit details
    Browse the repository at this point in the history