Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds support for go 1.17 on CI. #911

Closed
wants to merge 1 commit into from
Closed

chore: adds support for go 1.17 on CI. #911

wants to merge 1 commit into from

Conversation

jcchavezs
Copy link
Contributor

This PR adds check for go 1.17 on CI.

@jcchavezs
chore: adds support for go 1.17 on CI.
bb41e61 
Signed-off-by: José Carlos Chávez <jcchavezs@gmail.com>
bwplotka
bwplotka approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

LGTM, I think the failure is just flakiness, restarted. If these repeats let's investigate.

kakkoyun
kakkoyun requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatter needs to be run to fix styles with new build tags. Otherwise, it looks good to me.

@kakkoyun
Copy link
Member

Friendly ping @jcchavezs

@jeffwidman jeffwidman mentioned this pull request Dec 13, 2021
Closed
@mrueg mrueg mentioned this pull request Dec 17, 2021
Merged
@kakkoyun
Copy link
Member

Closing for the sake of #950

@kakkoyun kakkoyun closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun requested changes

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcchavezs @kakkoyun @bwplotka