Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: process_resident_memory_bytes detected is incorrect in Win7 32bit #734

Merged
merged 2 commits into from Apr 13, 2020
Merged

fix: process_resident_memory_bytes detected is incorrect in Win7 32bit #734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb7f92
fix: process_resident_memory_bytes detected is incorrect in Win7 32bit
cobolbaby Apr 10, 2020
c6babaf
feat: Change processMemoryCounters struct uint declaration to uintptr
cobolbaby Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 14 additions & 10 deletions prometheus/process_collector_windows.go
View file
Open in desktop
Expand Up @@ -33,18 +33,22 @@ var (
)

type processMemoryCounters struct {
// https://docs.microsoft.com/en-us/windows/desktop/api/psapi/ns-psapi-_process_memory_counters_ex
// System interface description
// https://docs.microsoft.com/en-us/windows/desktop/api/psapi/ns-psapi-process_memory_counters_ex

// Refer to the Golang internal implementation
// https://golang.org/src/internal/syscall/windows/psapi_windows.go
_ uint32
PageFaultCount uint32
PeakWorkingSetSize uint64
WorkingSetSize uint64
QuotaPeakPagedPoolUsage uint64
QuotaPagedPoolUsage uint64
QuotaPeakNonPagedPoolUsage uint64
QuotaNonPagedPoolUsage uint64
PagefileUsage uint64
PeakPagefileUsage uint64
PrivateUsage uint64
PeakWorkingSetSize uintptr
WorkingSetSize uintptr
QuotaPeakPagedPoolUsage uintptr
QuotaPagedPoolUsage uintptr
QuotaPeakNonPagedPoolUsage uintptr
QuotaNonPagedPoolUsage uintptr
PagefileUsage uintptr
PeakPagefileUsage uintptr
PrivateUsage uintptr
}

func getProcessMemoryInfo(handle windows.Handle) (processMemoryCounters, error) {
Expand Down