Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "factory" to make promauto work for custom registries #713

Merged
merged 3 commits into from Feb 14, 2020
Merged

Add a "factory" to make promauto work for custom registries #713

merged 3 commits into from Feb 14, 2020

Commits on Feb 13, 2020

  1. Remove obsolete references to Untyped from doc comments 

    Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Feb 13, 2020
    Copy the full SHA
    87f9434 View commit details
    Browse the repository at this point in the history

  2. Add a "factory" to make promauto work for custom registries 

    Also, update the package documentation. The concerns about the global
registry aren't really valid anymore because promauto now also works
with custom registries.

The musings about the http.DefaultMux are more a digression and
shouldn't be in a doc comment.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Feb 13, 2020
    Copy the full SHA
    92c1ac7 View commit details
    Browse the repository at this point in the history

  3. Add NewUntypedFunc to promauto 

    This constructor was simply forgotten.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Feb 13, 2020
    Copy the full SHA
    1c2884b View commit details
    Browse the repository at this point in the history