Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull out ...WithExemplar methods into separate interfaces #708

Merged
merged 1 commit into from Jan 27, 2020
Merged

Pull out ...WithExemplar methods into separate interfaces #708

merged 1 commit into from Jan 27, 2020

Commits on Jan 27, 2020

  1. Pull out ...WithExemplar methods into separate interfaces 

    This is, sadly, the only way to avoid a breaking change. The cost is
that anyone using exemplars has to perform a type assertion. This is,
however, a common pattern where interfaces turn out to need additional
methods in a stable library or only some implementations can provide
the additional methods (AKA "interface upgrade").

Needless to say that in v2 of this library, we'll do things in a more
straight forward way.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Jan 27, 2020
    Copy the full SHA
    f34b098 View commit details
    Browse the repository at this point in the history