chore: Refactor how base metrics are added to Sched metrics #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
| "go_threads", | ||
| } | ||
| matchedMetrics = append(matchedMetrics, baseMatrices...) | ||
| } | ||
| sort.Strings(matchedMetrics) |
There was a problem hiding this comment.
This will be optional now. We can remove the import as well in line 28.
Comment on lines
-22
to
-24
| "go_gc_cycles_automatic_gc_cycles_total", | ||
| "go_gc_cycles_forced_gc_cycles_total", | ||
| "go_gc_cycles_total_gc_cycles_total", |
There was a problem hiding this comment.
If we look at original file, the metrics were not sorted.
SachinSahu431
approved these changes
Mar 31, 2024
kakkoyun
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactoring to how base metrics are added to scheduler metrics.
I've noticed that this could be simplified while working on #1389. Some changes will conflict with the mentioned PR, but I'll solve them once one of them is merged :)
cc @SachinSahu431 @kakkoyun