Merging 1.18 back to main #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
(cherry picked from commit 2280fb1) Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Add 1.18 changelog
bwplotka
reviewed
Dec 28, 2023
| // a new http.Client based on the provided RoundTripper (or DefaultRoundTripper) will be used. | ||
| Client HttpClient | ||
| // a new one based on the provided RoundTripper (or DefaultRoundTripper) will be used. | ||
| Client *http.Client |
There was a problem hiding this comment.
This is weird, why we see this change again given 96f1aec
Like I see on main we have *http.Client as it should be already https://github.com/prometheus/client_golang/blob/main/api/client.go#L46
🤔
Something is off
There was a problem hiding this comment.
Let's try anyway, but this has little sense, this file shouldn't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.