New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge sparsehistogram branch into main #1150
Commits on Apr 7, 2020
-
Printf the structure of it instead of actually encoding it. Signed-off-by: beorn7 <beorn@grafana.com>
-
Encode sparse histograms in protobuf
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Apr 13, 2020
-
Add note about pow-of-10 precision issue
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Jan 29, 2021
Commits on Apr 3, 2021
Commits on Apr 30, 2021
-
-
Update prometheus/client_model
(now using sparsehistogram branch) Signed-off-by: beorn7 <beorn@grafana.com>
Commits on May 3, 2021
Commits on Jun 11, 2021
Commits on Jun 23, 2021
-
This seem what OTel is converging towards, see open-telemetry/oteps#149 . I see pros and cons with base-10 vs base-2. They are discussed in detail in that OTel PR, and the gist of the discussion is pretty much in line with my design doc. Since the balance is easy to tip here, I think we should go with base-2 if OTel picks base-2. This also seems to be in agreement with several proprietary solution (see again the discussion on that OTel PR.) The idea to make the number of buckets per power of 2 (or formerly 10) a power of 2 itself was also sketched out in the design doc already. It guarantees mergeability of different resolutions. I was undecided between making it a recommendation or mandatory. Now I think it should be mandatory as it has the additional benefit of playing well with OTel's plans. This commit also addresses a number of outstanding TODOs. Signed-off-by: beorn7 <beorn@grafana.com>
-
Add tests for sparse histogram
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Jun 24, 2021
-
Pin client_model to the most recent sparsehistogram commit
Signed-off-by: beorn7 <beorn@grafana.com>
-
Merge pull request #886 from prometheus/beorn7/histogram
Switch sparse histograms to base-2 buckets
Commits on Jun 29, 2021
-
Add TODO about bucket search optimization
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Jul 20, 2021
-
Allow a zero threshold of zero
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Aug 18, 2021
Commits on Aug 31, 2021
-
Implement strategy to limit the sparse bucket count
Signed-off-by: beorn7 <beorn@grafana.com>
-
Refactoring of sparse histograms
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Sep 1, 2021
-
Merge pull request #901 from prometheus/beorn7/histogram
Implement strategy to limit the sparse bucket count
Commits on Jan 11, 2022
Commits on Feb 2, 2022
Commits on May 13, 2022
Commits on May 15, 2022
-
-
Histogram: Fix bug with negative schemas (#1054)
* Histogram: Expose bug with negative schema Signed-off-by: beorn7 <beorn@grafana.com> * Histogram: Fix bug with negative schemas Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Jun 20, 2022
Commits on Jul 6, 2022
Commits on Jul 7, 2022
Commits on Jul 19, 2022
-
-
histograms: Move to new exposition protobuf format
Note that this is an incompatible change. To scrape this new format, the Prometheus server needs to be updated at the same time. PR incoming. Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Jul 20, 2022
-
Merge pull request #1092 from prometheus/beorn7/histogram
histograms: Move to new exposition protobuf format
Commits on Aug 23, 2022
Commits on Oct 6, 2022
-
sparse buckets: Fix handling of +Inf/-Inf/NaN observations
NaN observations now go to no bucket, but increment count (and effectively set sum to NaN, too). ±Inf observations now go to the bucket following the bucket that would have received math.MaxFloat64. The former is now the last bucket that can be created. The getLe is modified to return math.MaxFloat64 for the penultimate possible bucket. Also add a test for getLe. Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Oct 11, 2022
-
Merge pull request #1144 from prometheus/beorn7/histogram2
sparse buckets: Fix handling of +Inf/-Inf/NaN observations
Commits on Oct 19, 2022
-
-
Update prometheus/client_model dependency
Native histograms are now in a tagged version (v0.3.0). Signed-off-by: beorn7 <beorn@grafana.com>
-
examples: Adjust doc comment for native histograms
Signed-off-by: beorn7 <beorn@grafana.com>
-
Add SparseBucketsZeroThresholdZero and groom doc comments
Signed-off-by: beorn7 <beorn@grafana.com>
Commits on Oct 31, 2022
-
Avoid the term 'sparse' where possible
This intends to avoid confusing users by the subtle difference between a native histogram and a sparse bucket. Signed-off-by: beorn7 <beorn@grafana.com>
-