Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sparsehistogram branch into main #1150

Merged
merged 46 commits into from Oct 31, 2022
Merged

Merge sparsehistogram branch into main #1150

merged 46 commits into from Oct 31, 2022

Commits on Apr 7, 2020

  1. Demo sparse histograms

    Printf the structure of it instead of actually encoding it.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Apr 7, 2020
    Copy the full SHA
    c98db4e View commit details
    Browse the repository at this point in the history
  2. Encode sparse histograms in protobuf

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Apr 7, 2020
    Copy the full SHA
    abe540f View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Fix span offset

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Apr 13, 2020
    Copy the full SHA
    d1f5366 View commit details
    Browse the repository at this point in the history
  2. Add note about pow-of-10 precision issue

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Apr 13, 2020
    Copy the full SHA
    a9d0066 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Minor doc comment fixes

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jan 29, 2021
    Copy the full SHA
    08104a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Copy the full SHA
    d698336 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. Copy the full SHA
    ce36ee3 View commit details
    Browse the repository at this point in the history
  2. Update prometheus/client_model

    (now using sparsehistogram branch)
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Apr 30, 2021
    Copy the full SHA
    a9df0ba View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Fix test

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed May 3, 2021
    Copy the full SHA
    b7a540a View commit details
    Browse the repository at this point in the history
  2. Fix lint warning

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed May 3, 2021
    Copy the full SHA
    553ed73 View commit details
    Browse the repository at this point in the history
  3. Tidy go.sum

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed May 3, 2021
    Copy the full SHA
    97eb041 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Copy the full SHA
    5aa8534 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Switch to base-2 buckets

    This seem what OTel is converging towards, see
    open-telemetry/oteps#149 .
    
    I see pros and cons with base-10 vs base-2. They are discussed in
    detail in that OTel PR, and the gist of the discussion is pretty much
    in line with my design doc. Since the balance is easy to tip here, I
    think we should go with base-2 if OTel picks base-2. This also seems
    to be in agreement with several proprietary solution (see again the
    discussion on that OTel PR.)
    
    The idea to make the number of buckets per power of 2 (or formerly 10)
    a power of 2 itself was also sketched out in the design doc
    already. It guarantees mergeability of different resolutions. I was
    undecided between making it a recommendation or mandatory. Now I think
    it should be mandatory as it has the additional benefit of playing
    well with OTel's plans.
    
    This commit also addresses a number of outstanding TODOs.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 23, 2021
    Copy the full SHA
    31318b7 View commit details
    Browse the repository at this point in the history
  2. Add tests for sparse histogram

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 23, 2021
    Copy the full SHA
    6c4e0ef View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Pin client_model to the most recent sparsehistogram commit

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 24, 2021
    Copy the full SHA
    5142344 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #886 from prometheus/beorn7/histogram

    Switch sparse histograms to base-2 buckets
    beorn7 committed Jun 24, 2021
    Copy the full SHA
    43f31c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Add TODO about bucket search optimization

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jun 29, 2021
    Copy the full SHA
    aa6f67a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Allow a zero threshold of zero

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jul 20, 2021
    Copy the full SHA
    9ef5f90 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Copy the full SHA
    84fcaff View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Implement strategy to limit the sparse bucket count

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Aug 31, 2021
    Copy the full SHA
    2409960 View commit details
    Browse the repository at this point in the history
  2. Refactoring of sparse histograms

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Aug 31, 2021
    Copy the full SHA
    263be8d View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Merge pull request #901 from prometheus/beorn7/histogram

    Implement strategy to limit the sparse bucket count
    beorn7 committed Sep 1, 2021
    Copy the full SHA
    dfbcc28 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Copy the full SHA
    5b19c55 View commit details
    Browse the repository at this point in the history
  2. Fix typo in doc comment

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jan 11, 2022
    Copy the full SHA
    70253f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Copy the full SHA
    294cca4 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Fix conflicts

    Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
    kakkoyun committed May 13, 2022
    Copy the full SHA
    a27b6d7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e203144 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Copy the full SHA
    b237230 View commit details
    Browse the repository at this point in the history
  2. Histogram: Fix bug with negative schemas (#1054)

    * Histogram: Expose bug with negative schema
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    
    * Histogram: Fix bug with negative schemas
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed May 15, 2022
    Copy the full SHA
    eb59a7b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Copy the full SHA
    6ba7871 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Copy the full SHA
    525d042 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a516626 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    e93e384 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Copy the full SHA
    5a321c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Copy the full SHA
    6141a07 View commit details
    Browse the repository at this point in the history
  2. histograms: Move to new exposition protobuf format

    Note that this is an incompatible change. To scrape this new format,
    the Prometheus server needs to be updated at the same time. PR
    incoming.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Jul 19, 2022
    Copy the full SHA
    8cbcd40 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Merge pull request #1092 from prometheus/beorn7/histogram

    histograms: Move to new exposition protobuf format
    beorn7 committed Jul 20, 2022
    Copy the full SHA
    ec86ef1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Copy the full SHA
    95cf173 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. sparse buckets: Fix handling of +Inf/-Inf/NaN observations

    NaN observations now go to no bucket, but increment count (and
    effectively set sum to NaN, too).
    
    ±Inf observations now go to the bucket following the bucket that would
    have received math.MaxFloat64. The former is now the last bucket that
    can be created.
    
    The getLe is modified to return math.MaxFloat64 for the penultimate
    possible bucket.
    
    Also add a test for getLe.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Oct 6, 2022
    Copy the full SHA
    6942f9e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge pull request #1144 from prometheus/beorn7/histogram2

    sparse buckets: Fix handling of +Inf/-Inf/NaN observations
    beorn7 committed Oct 11, 2022
    Copy the full SHA
    25bc188 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Copy the full SHA
    111fae1 View commit details
    Browse the repository at this point in the history
  2. Update prometheus/client_model dependency

    Native histograms are now in a tagged version (v0.3.0).
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Oct 19, 2022
    Copy the full SHA
    4e71e6f View commit details
    Browse the repository at this point in the history
  3. examples: Adjust doc comment for native histograms

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Oct 19, 2022
    Copy the full SHA
    58a8ca4 View commit details
    Browse the repository at this point in the history
  4. Add SparseBucketsZeroThresholdZero and groom doc comments

    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Oct 19, 2022
    Copy the full SHA
    d31f13b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Avoid the term 'sparse' where possible

    This intends to avoid confusing users by the subtle difference between
    a native histogram and a sparse bucket.
    
    Signed-off-by: beorn7 <beorn@grafana.com>
    beorn7 committed Oct 31, 2022
    Copy the full SHA
    e92a8c7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    fffb76c View commit details
    Browse the repository at this point in the history