Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: process_resident_memory_bytes detected is incorrect in Win7 32bit #734

Merged
merged 2 commits into from Apr 13, 2020
Merged

fix: process_resident_memory_bytes detected is incorrect in Win7 32bit #734

merged 2 commits into from Apr 13, 2020

Conversation

cobolbaby
Copy link
Contributor

Ref: #728

@cobolbaby
fix: process_resident_memory_bytes detected is incorrect in Win7 32bit
0bb7f92 
Ref: #728
Signed-off-by: Cobolbaby <Zhang.Xing-Long@inventec.com>
@beorn7
Copy link
Member

beorn7 commented Apr 11, 2020

Cool. Thank you.

I have seen https://golang.org/src/internal/syscall/windows/psapi_windows.go now, where they use uintptr rather than uint I guess it doesn't really make a difference in practice, but is there perhaps a reason for that, and would uintptr be even better here?

@cobolbaby
Copy link
Contributor Author

@beorn7 No problem after verification．

beorn7
beorn7 approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do it this way for now. Thanks again.

@beorn7 beorn7 merged commit efb148c into prometheus:master Apr 13, 2020
This was referenced Mar 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beorn7 beorn7 beorn7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cobolbaby @beorn7