Skip to content

Commit

Permalink
Bump minimum required Go version to 1.16
Browse files Browse the repository at this point in the history
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
  • Loading branch information
mrueg committed Apr 13, 2022
1 parent 2417284 commit 879540f
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
4 changes: 0 additions & 4 deletions .circleci/config.yml
Expand Up @@ -46,10 +46,6 @@ workflows:
client_golang:
jobs:
# Refer to README.md for the currently supported versions.
- test:
name: go-1-15
go_version: "1.15"
run_lint: true
- test:
name: go-1-16
go_version: "1.16"
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,7 @@
## Unreleased

* [CHANGE] Minimum required Go version is now 1.16.

## 1.12.1 / 2022-01-29

* [BUGFIX] Make the Go 1.17 collector concurrency-safe #969
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -10,7 +10,7 @@ This is the [Go](http://golang.org) client library for
instrumenting application code, and one for creating clients that talk to the
Prometheus HTTP API.

__This library requires Go1.15 or later.__
__This library requires Go1.16 or later.__

## Important note about releases and stability

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -12,4 +12,4 @@ require (
google.golang.org/protobuf v1.28.0
)

go 1.15
go 1.16
4 changes: 1 addition & 3 deletions prometheus/collectors/dbstats_collector_test.go
Expand Up @@ -50,9 +50,7 @@ func TestDBStatsCollector(t *testing.T) {
"go_sql_wait_duration_seconds_total",
"go_sql_max_idle_closed_total",
"go_sql_max_lifetime_closed_total",
}
if runtime.Version() >= "go1.15" {
names = append(names, "go_sql_max_idle_time_closed_total")
"go_sql_max_idle_time_closed_total",
}
type result struct {
found bool
Expand Down

0 comments on commit 879540f

Please sign in to comment.