Don't set a default Docker version for setup_remote_docker #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning to a default version of Docker has triggered unexpected failures and the only solution was to bump the version in the project's CI configuration (see [1]). [1] prometheus/alertmanager#3177 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
matthiasr
approved these changes
Jan 18, 2023
matthiasr
added a commit
to prometheus/influxdb_exporter
that referenced
this pull request
Jan 26, 2023
cf. prometheus/circleci#28 Signed-off-by: Matthias Rampke <matthias@prometheus.io>
matthiasr
added a commit
that referenced
this pull request
Jan 26, 2023
There is no `latest` tag for this so we need to select a specific Go version :/ We weren't using recent Go versions before #28 either however, since the old image didn't get updated anymore. https://hub.docker.com/r/cimg/go/tags?page=1 Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning to a default version of Docker has triggered unexpected failures and the only solution was to bump the version in the project's CI configuration (see [1]).
[1] prometheus/alertmanager#3177
Signed-off-by: Simon Pasquier spasquie@redhat.com