Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert metric reports different results to what the user sees via API #2943

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Alert metric reports different results to what the user sees via API #2943

merged 2 commits into from
Jun 16, 2022

Commits on Jun 16, 2022

  1. Alert metric reports different results to what the user sees via API 

    Fixes prometheus#1439 and prometheus#2619.

The previous metric is not _technically_ reporting incorrect results as the alerts _are_ still around and will be re-used if that same alert (equal fingerprint) is received before it is GCed. Therefore, I have kept the old metric under a new name `alertmanager_marked_alerts` and repurpose the current metric to match what the user sees in the UI.

Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    da72e14 View commit details
    Browse the repository at this point in the history

  2. fix test 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    90f0c5b View commit details
    Browse the repository at this point in the history