docs: Fix default value of send_resolved for sns_configs #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekketsuuu
force-pushed
the
nekketsuuu-sns-resolved
branch
from
7b180e4
to
2d1ec53
Compare
|
Can you rebase this on top of |
nekketsuuu
force-pushed
the
nekketsuuu-sns-resolved
branch
2 times, most recently
from
14e51bf
to
a8f0c83
Compare
Signed-off-by: Takuma Ishikawa <nekketsuuu@users.noreply.github.com>
nekketsuuu
force-pushed
the
nekketsuuu-sns-resolved
branch
from
a8f0c83
to
aadee35
Compare
@roidelapluie Done! |
|
thanks! |
roidelapluie
added a commit
that referenced
this pull request
Oct 1, 2021
docs: Fix default value of send_resolved for sns_configs (#2724)
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
…2724) Signed-off-by: Takuma Ishikawa <nekketsuuu@users.noreply.github.com>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
…2724) Signed-off-by: Takuma Ishikawa <nekketsuuu@users.noreply.github.com> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
mike2194
pushed a commit
to paxosglobal/alertmanager
that referenced
this pull request
Mar 3, 2022
…2724) Signed-off-by: Takuma Ishikawa <nekketsuuu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs say the default value of
send_resolvedofsns_configs, introduced at #2615, isfalse. On the other hand, implementation says it'strue.alertmanager/config/notifiers.go
Lines 133 to 136 in e35efbd
Personally I prefer it's
false, but this feature has been already released. So I leave the value as it is and fix the docs.