Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS SNS receiver #2615
Add AWS SNS receiver #2615
Changes from 4 commits
19e74f9
5dcf4f5
74d1527
009f8b1
72d63a5
6519c39
af8406a
68fa1bf
b509a5b
8d3b1b5
889fa96
c48b54b
3a63cc2
6ada9a6
756cdda
9d37d6c
3446b35
a56305a
d4ff90b
b9b53f1
63f9082
4ebcaf9
8911051
dfb4d1f
9ff4ac3
30a83f7
bd82f70
25e6d4e
208bed6
1322abd
077b20d
7ecb6bc
4c2a5f1
51b9368
a1260af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the comment here, but applies to many config options. If you look at the specs in #2559, you can see many config options should actually be
tmpl_string
. The string is not evaluated as a template here (correct me if I'm wrong), but I think you should. As an example, look attmplText()
usage in the Slack integration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that's part of the original specifications but I'm not sure I fully understand why we set it to the group key's hash. To my understanding (but I may be wrong) is that the 5-minutes deduplication time window done by SNS will conflict with the Alertmanager
group_interval
if it's set less to 5 minutes because we may loose new alerts added to the group because of the SNS deduplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I confirmed the group key hash isn't unique enough to handle a message with the same title but different labels send in the 5 minute SNS de-duplication window. I'll ask in the issue, we're also missing a message group id for FIFO queues that is required by AWS.