Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint and switch to the revive #4089

Merged
merged 3 commits into from Jun 9, 2021
Merged

Bump golangci-lint and switch to the revive #4089

merged 3 commits into from Jun 9, 2021

Conversation

nabokihms
Copy link
Contributor

  • Bump golangci-lint
  • Replace the deprecated golint with the closest linter by its features - revive

Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint.

Release Note Template (will be copied)

@nabokihms nabokihms requested review from paulfantom and a team as code owners June 8, 2021 13:53
@simonpasquier
Copy link
Contributor

thanks for doing this! lgtm

paulfantom
paulfantom approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green ;)

@nabokihms
Bump golag-ci lint version to 1.40.1
2627cc3 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
Bump linter on CI
c74df07 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
Fix promlinter and examples
aa7042a 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms
Copy link
Contributor Author

I ran code gen and fixed promlint command. Everything should be ok now.

@simonpasquier simonpasquier merged commit 9fcdff9 into prometheus-operator:master Jun 9, 2021
@simonpasquier
Copy link
Contributor

thanks!

@simonpasquier simonpasquier mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce godoc comments when linting go code in the CI
3 participants
@nabokihms @simonpasquier @paulfantom