Add dmslave_info textfile collector #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add textfile collector to count the number of lun devices associated with device-mapper slaves and expose as Prometheus metrics. Signed-off-by: Saket Sinha <saket.sinha@cloud.ionos.com>
dswarbrick
reviewed
Sep 5, 2019
|
|
||
| dm = [x for x in os.listdir(sysfs+'virtual/block/') if x.startswith('dm')] | ||
| for dx in dm: | ||
| dm_sd = os.listdir(sysfs+'virtual/block/'+dx+'/slaves/') |
There was a problem hiding this comment.
os.path.join() would be a more Pythonic way of doing this.
dswarbrick
reviewed
Sep 5, 2019
| ['dm_device', 'lun_name'], | ||
| registry=registry) | ||
|
|
||
| dm = [x for x in os.listdir(sysfs+'virtual/block/') if x.startswith('dm')] |
There was a problem hiding this comment.
Why not just use glob.glob(sysfs+'virtual/block/dm-*') combined with os.path.basename() ?
|
Obsoleted by prometheus/procfs#412 I think we can close this. |
|
Closing as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add textfile collector to count the number of lun devices associated
with device-mapper slaves and expose as Prometheus metrics.
Signed-off-by: Saket Sinha saket.sinha@cloud.ionos.com