Update Go dependencies #109
Conversation
priteau
force-pushed
the
update-go-deps
branch
from
a3d935e
to
d425246
Compare
|
@priteau looks like the linting/tests failed, would you mind taking a look? https://github.com/andygrunwald/go-jira/releases/tag/v1.15.1 was released with a couple of additional fixes. |
priteau
force-pushed
the
update-go-deps
branch
2 times, most recently
from
435669a
to
fe80e79
Compare
|
There was a deprecation in |
|
Something with the go-jira packaging might have changed. I believe the go-jira imports need to be updated and be used like this now: See also: andygrunwald/go-jira#428 |
This includes go-jira v1.15.1 supporting Personal Access Tokens (PATs). Update go-jira imports [1] and go-kit imports [2]. [1] andygrunwald/go-jira#428 [2] go-kit/kit#1173 Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
|
I think we may be hitting this? golangci/golangci-lint#2195 The GitHub action uses 1.14.x, while locally I have 1.17.6, which may explain the difference in test output. |
|
Do you want to raise the golang version in these files and see if that fixes it? https://github.com/prometheus-community/jiralert/blob/master/.github/workflows/build-docker.yaml#L13 |
We are trying to avoid the following linting errors:
Error: pkg/notify/notify.go:158:4: issueComp declared but not used (typecheck)
issueComp, err := r.tmpl.Execute(component, data)
^
Error: pkg/notify/notify.go:168:7: k declared but not used (typecheck)
for k, v := range data.GroupLabels {
^
|
I am not sure it makes sense to bump Go version requirements just for a linting issue. |
|
Unrelated to this change, I think it makes sense if the project is built with a supported version of golang (which at this point is 1.16 and 1.17). |
|
This will certainly conflict with the PR I've sent adding support for PAT in jiralert 😅 #110 |
|
Closing since go-jira was updated to v1.15.1 in #110. |
This includes go-jira v1.15.0 supporting Personal Access Tokens (PATs).