Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prometheus_scrape_config feature #237

Conversation

romanbilenko174
Copy link
Contributor

@romanbilenko174 romanbilenko174 commented Oct 21, 2023

Added prometheus_scrape_config_files support as mentioned in #145

@romanbilenko174 romanbilenko174 changed the title Patch add scrape config files Add prometheus_scrape_config functionality Oct 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

@romanbilenko174 romanbilenko174 changed the title Add prometheus_scrape_config functionality Add prometheus_scrape_config feature Oct 21, 2023
@SuperQ SuperQ changed the title Add prometheus_scrape_config feature feat: Add prometheus_scrape_config feature Nov 14, 2023
@gardar
Copy link
Member

gardar commented Dec 14, 2023

Can you please fix the DCO?

@Lycowolf
Copy link
Contributor

Lycowolf commented Feb 12, 2024

Hi, I am currently being blocked by #145 and would like to have this fixed.

I read the PR and I think there's nothing wrong with it technically. Because the PR is more than 3 months old, I am volunteering to take over this PR and drive it to finsh. IIUC the only missing piece is the missing sign-off, but (as I am not the author), I can't really provide that.

Is there a way forward? Or do I have to write my own version and submit that?

@gardar
Copy link
Member

gardar commented Feb 12, 2024

Is there a way forward? Or do I have to write my own version and submit that?

Yes that would be the correct way for you to "take over".

@romanbilenko174 ping

Can you please fix the DCO?

@Lycowolf
Copy link
Contributor

My version of this is #292

@gardar gardar added the duplicate This issue or pull request already exists label May 29, 2024
@gardar
Copy link
Member

gardar commented May 29, 2024

superseded by #368

@gardar gardar closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants