New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-close stale issues and pull requests #907
Conversation
Use the https://github.com/actions/stale to automatically mark pull requests and issues as "stale" and close them if they have no activity. To disable, set `stale: false`.
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 78.46% 84.54% +6.07%
==========================================
Files 88 107 +19
Lines 3181 4101 +920
Branches 809 1026 +217
==========================================
+ Hits 2496 3467 +971
+ Misses 683 631 -52
- Partials 2 3 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Co-authored-by: Eli Polonsky <epolon@amazon.com>
@eladb The docs for "actions/stale" says "If an update/comment occur on stale issues or pull requests, the stale label will be removed and the timer will restart" It doesn't look like that is happening with the issues you commented on (the label remains). Is it possible this is just a side effect of changing the label post-hoc from "Stale" to "stale"? Or just a bug? |
Did the stale job run? It is executed every 24h so I think it might have not been executed yet. |
On #450 I posted a comment, and the latest run didn't remove the label. Here are the related logs:
It's odd that it says "Issue marked stale on: 2021-07-04T20:16:51Z" when the stale label was added five days prior. I think it may be the same bug mentioned here: actions/stale#441 They have a PR open that will fix it, so let's wait and see if that resolves it. |
@eladb Disable for now? 😕 |
Besides adding/removing the label, is the workflow broken? Seems like it's doing its job and if users add a comment it won't close the issue. No? |
Introduce a default behavior to all project types which automatically marks issues and pull requests with a
Stale
label after a period of inactivity and then closes them.The defaults stale/close periods in days are:
This feature is only available on projects hosted on GitHub and uses the actions/stale action to automatically mark pull requests and issues as "stale" and close them if they have no activity.
To disable, set
stale: false
in the project definition.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.