Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RFC ESM Support Implementation #3467

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

giseburt
Copy link
Contributor

Fixes #3447

DRAFT FOR NOW


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 66.86391% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 96.21%. Comparing base (fe06f0b) to head (eaae5c8).

Files Patch % Lines
src/typescript/projenrc.ts 61.40% 44 Missing ⚠️
src/javascript/jest.ts 40.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3467      +/-   ##
==========================================
- Coverage   96.34%   96.21%   -0.13%     
==========================================
  Files         192      192              
  Lines       37627    37789     +162     
  Branches     3519     3532      +13     
==========================================
+ Hits        36251    36359     +108     
- Misses       1376     1430      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: ESM project support in NodeProject and TypeScriptProject
2 participants