Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node)!: default to node16 and remove jsii/superchain from workflows #2510

Merged
merged 1 commit into from Mar 21, 2023

Commits on Mar 21, 2023

  1. feat(node)!: default to node16 and do not use jsii/superchain image…

    … in workflows
    
    BREAKING CHANGE: default to node16
    To use any other Node version, explicitly provide the desired version number
    
    BREAKING CHANGE: remove `jsii/superchain` image from AwsCdkConstructLibrary workflows
    Using `jsii/superchain` provides no tangible benefit over installing dependencies with GitHub Actions.
    However because AWS CDK Constructs often require to run docker commands, with image GitHub Action workflows end up attempting to run Docker in Docker.
    This is not trivial to achieve (see #2094 & aws/aws-cdk#8799).
    Additionally the existing build and package workflows had an inconsistent usage of the image, causing further problems.
    
    To restore the old behavior, set `options.workflowContainerImage` to the desired image.
    
    Fixes #2094
    Closes #1065
    mrgrain committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d303e2d View commit details
    Browse the repository at this point in the history