Skip to content

Commit

Permalink
fix: jsdom typings override is no longer needed (#1278)
Browse files Browse the repository at this point in the history
Closes #1264

Issue has been fixed upstream in jest@27.4.3 (ref: jestjs/jest#12098)

---
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • Loading branch information
Chriscbr committed Dec 2, 2021
1 parent 40451ae commit 3ccbf15
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 24 deletions.
7 changes: 0 additions & 7 deletions .projenrc.js
Expand Up @@ -185,11 +185,4 @@ project.npmignore.exclude('/SECURITY.md');
project.npmignore.exclude('/.gitattributes');
project.npmignore.exclude('/.gitpod.yml');

// Workaround for @types/jsdom issues due to upgrade to jest@27.4.0 as mentioned in https://github.com/projen/projen/issues/1264#issuecomment-982365744
if (project.package.packageManager === NodePackageManager.YARN) {
project.package.addField('resolutions', {
'jest-environment-jsdom': '27.3.1',
});
}

project.synth();
3 changes: 0 additions & 3 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 14 additions & 14 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3ccbf15

Please sign in to comment.