Pin lint dependencies to bandit 1.7.2 #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bandit core 1.7.3 was just released (https://github.com/PyCQA/bandit/releases/tag/1.7.3) and the flake8-bandit package uses this latest version. However, flake8 is currently failing. More specifically, the change in PyCQA/bandit@0f4a495 is causing the below issue: ``` Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 125, in worker result = (True, func(*args, **kwds)) File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar return list(map(*args)) File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 687, in _run_checks return checker.run_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 597, in run_checks self.run_ast_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 500, in run_ast_checks for (line_number, offset, text, _) in runner: File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 85, in run for warn in self._check_source(): File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 59, in _check_source bnv = BanditNodeVisitor( TypeError: __init__() missing 1 required positional argument: 'metrics' ``` Therefore we temporarily pin the bandit version to 1.7.2 until the 1.7.3 version is compatible with flake8-bandit.
|
See also tylerwince/flake8-bandit#21 |
snazy
approved these changes
Feb 28, 2022
omarsmak
approved these changes
Feb 28, 2022
|
What a morning where one of the Python dependencies just break your build :D. Thanks @nastra ! |
Codecov Report
@@ Coverage Diff @@
## main #3458 +/- ##
============================================
- Coverage 86.87% 86.86% -0.01%
+ Complexity 2672 2671 -1
============================================
Files 342 342
Lines 15041 15041
Branches 1108 1108
============================================
- Hits 13067 13066 -1
Misses 1586 1586
- Partials 388 389 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snazy
added a commit
to snazy/nessie-demos
that referenced
this pull request
Feb 28, 2022
Bandit core 1.7.3 was just released (https://github.com/PyCQA/bandit/releases/tag/1.7.3) and the flake8-bandit package uses this latest version. However, flake8 is currently failing. More specifically, the change in PyCQA/bandit@0f4a495 is causing the below issue: ``` Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 125, in worker result = (True, func(*args, **kwds)) File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar return list(map(*args)) File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 687, in _run_checks return checker.run_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 597, in run_checks self.run_ast_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 500, in run_ast_checks for (line_number, offset, text, _) in runner: File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 85, in run for warn in self._check_source(): File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 59, in _check_source bnv = BanditNodeVisitor( TypeError: __init__() missing 1 required positional argument: 'metrics' ``` Therefore we temporarily pin the bandit version to 1.7.2 until the 1.7.3 version is compatible with flake8-bandit. See also: projectnessie/nessie#3458
snazy
added a commit
to projectnessie/nessie-demos
that referenced
this pull request
Feb 28, 2022
Bandit core 1.7.3 was just released (https://github.com/PyCQA/bandit/releases/tag/1.7.3) and the flake8-bandit package uses this latest version. However, flake8 is currently failing. More specifically, the change in PyCQA/bandit@0f4a495 is causing the below issue: ``` Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 125, in worker result = (True, func(*args, **kwds)) File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar return list(map(*args)) File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 687, in _run_checks return checker.run_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 597, in run_checks self.run_ast_checks() File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8/checker.py", line 500, in run_ast_checks for (line_number, offset, text, _) in runner: File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 85, in run for warn in self._check_source(): File "/home/runner/work/nessie/nessie/python/.tox/lint/lib/python3.8/site-packages/flake8_bandit.py", line 59, in _check_source bnv = BanditNodeVisitor( TypeError: __init__() missing 1 required positional argument: 'metrics' ``` Therefore we temporarily pin the bandit version to 1.7.2 until the 1.7.3 version is compatible with flake8-bandit. See also: projectnessie/nessie#3458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bandit core 1.7.3 was just released
(https://github.com/PyCQA/bandit/releases/tag/1.7.3) and the
flake8-bandit package uses this latest version. However, flake8 is
currently failing.
More specifically, the change in PyCQA/bandit@0f4a495 is causing the below issue:
Therefore we temporarily pin the bandit version to 1.7.2 until the 1.7.3
version is compatible with flake8-bandit.