Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove visualization_old (mesa-viz-tornado) #2133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rht
Copy link
Contributor

@rht rht commented May 8, 2024

TODO:

This doesn't seem to be used as often as the current simple namespace.
@rht
Copy link
Contributor Author

rht commented May 8, 2024

This fixes the tests.

Copy link

github-actions bot commented May 8, 2024

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
Schelling small 🔵 -0.1% [-0.4%, +0.1%] 🔵 -0.7% [-1.0%, -0.5%]
Schelling large 🔵 -0.9% [-1.6%, -0.2%] 🔵 -2.0% [-2.9%, -1.2%]
WolfSheep small 🔵 -0.3% [-1.4%, +0.9%] 🔵 -1.1% [-1.4%, -0.8%]
WolfSheep large 🔵 -1.3% [-2.0%, -0.5%] 🔵 -2.3% [-3.9%, -0.7%]
BoidFlockers small 🔵 -0.1% [-0.8%, +0.6%] 🔵 -0.7% [-1.3%, -0.1%]
BoidFlockers large 🔵 -1.4% [-2.1%, -0.6%] 🔵 -0.3% [-1.1%, +0.3%]

@EwoutH EwoutH added the breaking Release notes label label May 8, 2024
@EwoutH EwoutH added this to the v3.0 milestone May 21, 2024
@EwoutH EwoutH requested review from jackiekazil and tpike3 May 29, 2024 13:24
Copy link
Contributor

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'm going to approve this. Let's cut the cord and focus on the future. The new space needs some work (like support for Cell spaces and PropertyLayers) but it's the future.

I would like more maintainers to pitch in and/or approve (at least a second) before merging though, since this is a big change.

@EwoutH EwoutH requested a review from Corvince May 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants