-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for https://github.com/projectmesa/mesa/issues/2117 #2118
base: main
Are you sure you want to change the base?
Conversation
…ith muliple options and a fix of the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for catching this! You are indeed right, the closest choice is deterministic while it shouldn't be.
I have one suggestion to implement it a bit cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see that the test passes and my example that uses this code is not showing the issue anymore. SO +1
Awesome! Let’s now try to make it faster :) |
@EwoutH Do we want to wait for speed on this one or merge it and do a 2.3.1 to fix the bug? |
this is a test and bug fix for the issue in :
#2117