Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonNull annotations to test cases for testing annotation copying #3589

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burdoto
Copy link

@burdoto burdoto commented Jan 17, 2024

Closes #3318

This PR introduces @NonNull annotations as part of @Data and @Value classes' fields in order to be copied from fields to constructors, getters and setters as requested in #3318 (comment).

@burdoto
Copy link
Author

burdoto commented Jan 17, 2024

After writing and testing the modified Test case, I noticed that this does in fact function with the @lombok.NonNull annotation.
The reported issue applies to external annotations such as org.intellij.lang.annotations.Language (as reported in #3318 (comment)) that are affected. However, for the test case, as a new contributor, I dont have enough project insight to correctly introduce external annotations to this test case (let alone since maven fails to import the whole project).

@burdoto burdoto marked this pull request as draft January 17, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Custom nullable annotations are not copied to constructors and methods for Value/Data classes
1 participant