Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JDK 19 #3251

Merged
merged 4 commits into from Jan 11, 2023
Merged

Add support for JDK 19 #3251

merged 4 commits into from Jan 11, 2023

Conversation

Rawi01
Copy link
Collaborator

@Rawi01 Rawi01 commented Aug 25, 2022

This PR requires a new lombok.patcher release (0.46) with ASM 9.3.

Issues: #3211

@SimSonic
Copy link

SimSonic commented Oct 3, 2022

@Rawi01 hi, it is possible for you to finish PR?

@Rawi01
Copy link
Collaborator Author

Rawi01 commented Oct 4, 2022

I left this as a draft because I had no time to test it properly and it needs an updated lombok patcher (that's why the automated build fails).

@jkickic jkickic mentioned this pull request Oct 5, 2022
@Rawi01 Rawi01 marked this pull request as ready for review October 30, 2022 18:46
@Rawi01
Copy link
Collaborator Author

Rawi01 commented Oct 30, 2022

@rzwitserloot This PR can be merged as soon as you update the patcher

@alexanderankin
Copy link

related patcher pr projectlombok/lombok.patcher#11

@HJK181
Copy link

HJK181 commented Dec 13, 2022

Any updates?

@rzwitserloot rzwitserloot merged commit 9388dbc into projectlombok:master Jan 11, 2023
@rzwitserloot
Copy link
Collaborator

Lombok release with JDK19 support imminent.

@savvyben
Copy link

How imminent?

@rspilker
Copy link
Collaborator

rspilker commented Jan 18, 2023

We want to ship a release tomorrow. But we didn't get any feedback, negative nor positive, on the edge release, which does not give us much confidence in the release.

@Harmelodic
Copy link

Feedback from me:

Using lombok 1.18.24 with JDK 19, I got the error:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
...
[ERROR] /redacted/path/to/class/Thing.java:[10,1] Ignoring static constructor name: explicit @XxxArgsConstructor annotation present; its `staticName` parameter will be used.

where the class was using @Value(staticConstructor = "of")

Using lombok edge-SNAPSHOT with JDK 19, I got:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

So it's a big 👍 from me!

@SimSonic
Copy link

A little bit of positive feedback.

Enterprise multi-module maven project with codebase size up to 280k+ LoC recompiles successfully, all tests are green.

Using lombok-edge.jar downloaded from site and both JDK 17 and 19.

@dstango
Copy link

dstango commented Jan 18, 2023

Question:
In #3180 (comment) and #3180 (comment) you said you intended to (maybe partly) roll-back the copying of constraint annotations to getters/setters and release a 1.18.26 soon.
I can't find any PR in the issue #3180, that resolves the issue (plus it's still open). Do I miss something? Or did you change your mind about it?

@Rawi01
Copy link
Collaborator Author

Rawi01 commented Jan 18, 2023

@dstango 1473389

@dstango
Copy link

dstango commented Jan 19, 2023

@Rawi01 thank you!

@savvyben
Copy link

when is the release being cut?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants