Resolve var/val only once in eclipse #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's some fancy footwork on the compliance level stuff. Love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2985
The actual problem was the changed method signature of
LocalDeclaration::resolve. I also changed the ecj test system to set a lower java version than the maximum supported one. This is something that happens a lot in real world usage e.g. current eclipse but java 8 project and is required to test the < java 10valcode. I also updated the tests to no longer stop if an error occours to trigger the reported bug. This also revealed another bug related to conditional expressions (eclipse does not throw an AbortCompilation during normal compilation)