[fixes #2768] Making the Builder constructor's visibility configurable. #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eeps PACKAGE the default.
|
The way it works now was intentional. Reasoning stated in, and awaiting feedback at, linked issue #2768 before proceeding on this PR. If this is discouraging, that sucks :( - good job on the PR 👍 though; proper styling applied, added name to authors file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Builder constructor's visibility configurable. Also fixes #2768, however, I just stumbled upon that bug while trying to fix our own problem.
The problem we had in our project is that we need to use Jackson and configure it so that it doesn't override access modifiers (set MapperFeature.CAN_OVERRIDE_ACCESS_MODIFIERS to false) because in our runtime environment (embedded) there is a SecurityManager which doesn't allow that and we have no control over that. In this configuration Jackson cannot work unless the Builder's constructor is public. Making this configurable while keeping the default visibility PACKAGE, existing code is unaffected, but we can add the parameter to our Builder annotations which is more elegant than having to explicitly write the Builder classes.