Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CustomLogger support #2121

Closed
wants to merge 1 commit into from
Closed

Conversation

sbartram
Copy link

@sbartram sbartram commented May 7, 2019

Add support for a custom logger which is specified via lombok.config

@daliclass
Copy link
Contributor

daliclass commented May 7, 2019

I like the feature, fantastic work!

Can we also implement this functionality in lombok.eclipse.handlers.HandleLog and add some tests for the new annotation.

@rzwitserloot
Copy link
Collaborator

Hmm, did you see PR #2086 before you wrote this? 😲

@sbartram
Copy link
Author

sbartram commented May 9, 2019 via email

@juriad
Copy link

juriad commented May 9, 2019

I expect to push a new version on the weekend (I am changing the configuration); maybe you could help with review and testing then?

@sbartram
Copy link
Author

sbartram commented May 9, 2019

Absolutely, I can help with testing and review.

@rzwitserloot
Copy link
Collaborator

awesome. I shall close this one then. We're keeping our eye on #2086, but we're off to Boston to brainstorm together with other open source maintainers about how to streamline the need for organisations to ensure proper maintenance of the open source libraries they rely on, and the maintainers of said libraries who are totally willing to do that, especially if they get some money for their troubles :) -- I'll try to review the PR in the plane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants