Update sybil dependency #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karen Feng <karen.feng@databricks.com>
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 92 92
Lines 4364 4364
Branches 386 386
=======================================
Hits 4086 4086
Misses 278 278 Continue to review full report at Codecov.
|
kianfar77
approved these changes
Aug 21, 2020
kianfar77
pushed a commit
to kianfar77/glow
that referenced
this pull request
Sep 4, 2020
Signed-off-by: Karen Feng <karen.feng@databricks.com> Signed-off-by: kianfar77 <kiavash.kianfar@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
pytest 6.0.0 treats deprecation warnings as errors by default, and old versions of sybil used an API deprecated in pytest 5.4.0. This PR updates our sybil dependency so we no longer use the deprecated API; these updates were made in 1.4.0.
This should unbreak our build.
How is this patch tested?
Run
docs/testafter updating pytest.Before: https://app.circleci.com/pipelines/github/projectglow/glow/1426/workflows/250215cb-503a-47b2-b918-cc7c672b011f/jobs/3121