Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for DNS over TLS (DOT) & Some bug fixes #41

Merged
merged 3 commits into from Jan 19, 2022
Merged

Adding support for DNS over TLS (DOT) & Some bug fixes #41

merged 3 commits into from Jan 19, 2022

Conversation

yabeow
Copy link
Contributor

@yabeow yabeow commented Jan 18, 2022

Hi there,

miekg/dns has built-in support for DNS over TLS (DOT), we should add this feature to retryabledns so other tools like dnsx could benefit from this. Here is an example of using DOT with retryabledns now:

client := retryabledns.New([]string{"dot:dns.google:853", "dot:1dot1dot1dot1.cloudflare-dns.com"}, 5)

d, err := client.QueryMultiple("example.com", []uint16{dns.TypeA})

This pull request also contains some bug fixes & other minor improvements.

@Mzack9999 Mzack9999 added the enhancement New feature or request label Jan 18, 2022
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Great work!

@yabeow
Copy link
Contributor Author

yabeow commented Jan 19, 2022

Hi everyone,

I've done some other performance improvements for hot parts like parsing resolvers. Please take a look at it 👍

Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit f7d02eb into projectdiscovery:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants