Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill the DNSData.ANY #137

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fill the DNSData.ANY #137

merged 2 commits into from
Jun 7, 2023

Conversation

ShubhamRasal
Copy link
Contributor

@ShubhamRasal ShubhamRasal commented Jun 6, 2023 •
edited

  • Populate the DNSData.ANY slice when any query is requested
  • Add the GetSOARecrods function which returns the slice of strings, required for nuclei and dnsx
    nuclei PR dnx PR

@ShubhamRasal
Fill the DNSDATA.ANY
0c12392
@ShubhamRasal
Add GetSOARecords fuction for DNSData.
230b4a6 
- This getSOA records are used the in nuclei, dnsx
@ShubhamRasal ShubhamRasal mentioned this pull request Jun 7, 2023
Merged
@ShubhamRasal ShubhamRasal self-assigned this Jun 7, 2023
@ShubhamRasal ShubhamRasal linked an issue Jun 7, 2023 that may be closed by this pull request
Populate the DNSData ANY when any query is requested #138
Closed
tarunKoyalwar
tarunKoyalwar approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@tarunKoyalwar
Copy link
Member

since we are going to use this in other PRs we probably should create new release to avoid invalid revision issues
cc: @ehsandeep

@ehsandeep ehsandeep merged commit ea74349 into main Jun 7, 2023
5 checks passed
@ehsandeep ehsandeep deleted the any-record-change branch June 7, 2023 21:35
@hachh hachh mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@Mzack9999 Mzack9999 Awaiting requested review from Mzack9999

Assignees

@ShubhamRasal ShubhamRasal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate the DNSData ANY when any query is requested
3 participants
@ShubhamRasal @tarunKoyalwar @ehsandeep