Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using atomic for internal counters #31

Merged
merged 3 commits into from
May 16, 2023
Merged

Using atomic for internal counters #31

merged 3 commits into from
May 16, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 7, 2023 •
edited

Closes #30

$ go test -race ./...
?       github.com/projectdiscovery/ratelimit/example   [no test files]
ok      github.com/projectdiscovery/ratelimit   38.060s

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 7, 2023
@Mzack9999 Mzack9999 self-assigned this May 7, 2023
@Mzack9999 Mzack9999 marked this pull request as ready for review May 7, 2023 22:04
tarunKoyalwar
tarunKoyalwar approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Mzack9999 Mzack9999 merged commit fd03f8b into main May 16, 2023
7 checks passed
@Mzack9999 Mzack9999 deleted the issue-30-race branch May 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race Condition in rate limit feature
2 participants
@Mzack9999 @tarunKoyalwar