Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Client TLS1.0 #2091

Merged
merged 2 commits into from Jun 4, 2022
Merged

Adding Client TLS1.0 #2091

merged 2 commits into from Jun 4, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 30, 2022 •
edited

Proposed changes

This PR lower the minimum required TLS to 1.0. Closes https://github.com/projectdiscovery/team-backlogs/issues/156

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Depends on: projectdiscovery/fastdialer#38

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label May 30, 2022
@Mzack9999 Mzack9999 self-assigned this May 30, 2022
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 1, 2022
@Mzack9999
Copy link
Member Author

TLS1.0 doesn't reflect in outgoing clienthello TLS handshake (left actual - nuclei, right expected - httpx):

Screenshot 2022-06-02 at 00 58 46

echo https://tls-v1-0.badssl.com:1010/ | go run . -id tech-detect -v
[WRN] [tech-detect] Could not execute request for https://tls-v1-0.badssl.com:1010: GET https://tls-v1-0.badssl.com:1010 giving up after 2 attempts: Get "https://tls-v1-0.badssl.com:1010": tls: server selected unsupported protocol version 301

@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Jun 3, 2022
@ehsandeep ehsandeep merged commit cc37382 into dev Jun 4, 2022
@ehsandeep ehsandeep deleted the maint-tls branch June 4, 2022 12:15
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mzack9999 @ehsandeep @LuitelSamikshya