Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending ASCII conversion support #620

Merged
merged 2 commits into from May 16, 2022
Merged

Extending ASCII conversion support #620

merged 2 commits into from May 16, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 15, 2022 •
edited

Description

This PR extends Ascii conversion support. Fixes #619

Notes

Depends on:

Example

$ echo "ουτοπία.δπθ.gr" | go run . -silent -ip
https://ουτοπία.δπθ.gr [192.108.114.44]

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 15, 2022
@Mzack9999 Mzack9999 self-assigned this May 15, 2022
@Mzack9999 Mzack9999 linked an issue May 15, 2022 that may be closed by this pull request
Issue with CLI output in case of unicode input #619
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label May 15, 2022
@ehsandeep ehsandeep merged commit 7f7d809 into dev May 16, 2022
@ehsandeep ehsandeep deleted the issue-619-output branch May 16, 2022 15:47
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with CLI output in case of unicode input
3 participants
@Mzack9999 @ehsandeep @LuitelSamikshya